Skip to content

Conversation

@Kalobi
Copy link
Member

@Kalobi Kalobi commented Sep 26, 2022

Improve custom vignettes in a few ways:

  • Allow customizing the audio (currently still defaults to the prologue audio for backwards compatibility).
  • No longer ends after a hardcoded wait duration, uses the CoreVignette approach instead.
  • Allow customizing wait times at the start and end (vanilla has a shorter initial wait time in CoreVignette than IntroVignette, the wait time at the end can be used e.g. to wait for a sound to finish as IntroVignette does).
  • Make sure the snow direction always gets applied, not just when reusing an existing HiresSnow (probably never matters).
  • Center all text lines for text with line breaks.
  • Make snow in vignette blow to the left by default to match vanilla.

The new wait time attributes, as well as the wind direction one, should also be documented on the wiki.

Copy link
Member

@coloursofnoise coloursofnoise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up 😅 I'll admit I didn't put a lot of thought into it when I first implemented it

@coloursofnoise coloursofnoise merged commit e19c7ea into EverestAPI:dev Dec 8, 2022
@Kalobi Kalobi deleted the textvignettetweaks branch January 16, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants