Don't do visibility checks for OfflinePlayers (#5375)

JRoy · mdcfe · web-flow · commit a1fa1e38f8c2 · 2023-07-01T16:41:56.000-04:00
Co-authored-by: MD &lt;1917406+mdcfe@users.noreply.github.com&gt;
diff --git a/Essentials/src/main/java/com/earth2me/essentials/User.java b/Essentials/src/main/java/com/earth2me/essentials/User.java
@@ -679,6 +679,9 @@ public boolean toggleAfk(final AfkStatusChangeEvent.Cause cause) {
 
     @Override
     public boolean isHiddenFrom(Player player) {
+        if (getBase() instanceof OfflinePlayer || player instanceof OfflinePlayer) {
+            return true;
+        }
         return !player.canSee(getBase());
     }
 

Original file line number	Diff line number	Diff line change
`@@ -679,6 +679,9 @@ public boolean toggleAfk(final AfkStatusChangeEvent.Cause cause) {`
`679`	`679`
`680`	`680`	`@Override`
`681`	`681`	`public boolean isHiddenFrom(Player player) {`
	`682`	`+ if (getBase() instanceof OfflinePlayer \|\| player instanceof OfflinePlayer) {`
	`683`	`+ return true;`
	`684`	`+ }`
`682`	`685`	`return !player.canSee(getBase());`
`683`	`686`	`}`
`684`	`687`