Skip to content

Source Jar for shaded kryo5 has wrong package declaration inside files #870

@leonard84

Description

@leonard84

Describe the bug
The sources jar has relocated the source files to the correct package folder, but it didn't modify the package declaration inside the packages.

It is package com.esotericsoftware.kryo; while it should be package com.esotericsoftware.kryo.kryo5;.

This is also the probable cause of an issue with IntelliJ. When both kryo 4 and the shaded kryo5 are used as dependencies, then Intellij has problems jumping to the correct sources.

To Reproduce
Download the jar and look at the sources and see the mismatch

Environment:

  • Kryo Version: 5.2.0

Additional context
This could be solved by modifying the sources before packaging them in the jar, e.g., https://stackoverflow.com/a/2196729/16358266.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions