Override writeChar and readChar methods to use unsafe: writeChar now performs about 125% faster and readChar 10% faster than overriden safe versions.

serverperformance · serverperformance · commit 45f510de2dc0 · 2014-08-21T12:07:48.000+02:00
diff --git a/src/com/esotericsoftware/kryo/io/UnsafeInput.java b/src/com/esotericsoftware/kryo/io/UnsafeInput.java
@@ -16,7 +16,7 @@
  * <p>
  * Important notes:<br/>
  * <li>Bulk operations, e.g. on arrays of primitive types, are always using native byte order.</li>
- * <li>Fixed-size int, long, short, float and double elements are always read using native byte order.</li>
+ * <li>Fixed-size char, int, long, short, float and double elements are always read using native byte order.</li>
  * <li>Best performance is achieved if no variable length encoding for integers is used.</li>
  * <li>Serialized representation used as input for this class should always be produced using @link{UnsafeOutput}</li>
  * </p>
@@ -106,6 +106,16 @@ public double readDouble () throws KryoException {
 		position += 8;
 		return result;
 	}
+	
+	// char
+	
+	public char readChar () throws KryoException {
+		require(2);
+		char result = unsafe().getChar(buffer, byteArrayBaseOffset + position);
+		position += 2;
+		return result;
+	}
+
 
 	public int readInt (boolean optimizePositive) throws KryoException {
 		if (!varIntsEnabled)
diff --git a/src/com/esotericsoftware/kryo/io/UnsafeMemoryInput.java b/src/com/esotericsoftware/kryo/io/UnsafeMemoryInput.java
@@ -17,7 +17,7 @@
  * <p>
  * Important notes:<br/>
  * <li>Bulk operations, e.g. on arrays of primitive types, are always using native byte order.</li>
- * <li>Fixed-size int, long, short, float and double elements are always read using native byte order.</li>
+ * <li>Fixed-size char, int, long, short, float and double elements are always read using native byte order.</li>
  * <li>Best performance is achieved if no variable length encoding for integers is used.</li>
  * <li>Serialized representation used as input for this class should always be produced using @link{UnsafeMemoryOutput}</li>
  * </p>
@@ -127,8 +127,10 @@ public byte readByte () throws KryoException {
 
 	/** Reads a 2 byte char. */
 	public char readChar () throws KryoException {
-		super.niobuffer.position(position);
-		return super.readChar();
+		require(2);
+		char result = unsafe().getChar(bufaddress + position);
+		position += 2;
+		return result;
 	}
 
 	/** Reads an 8 byte double. */
diff --git a/src/com/esotericsoftware/kryo/io/UnsafeMemoryOutput.java b/src/com/esotericsoftware/kryo/io/UnsafeMemoryOutput.java
@@ -21,7 +21,7 @@
  * Important notes:<br/>
  * <li>This class increases performance, but may result in bigger size of serialized representation.</li>
  * <li>Bulk operations, e.g. on arrays of primitive types, are always using native byte order.</li>
- * <li>Fixed-size int, long, short, float and double elements are always written using native byte order.</li>
+ * <li>Fixed-size char, int, long, short, float and double elements are always written using native byte order.</li>
  * <li>Best performance is achieved if no variable length encoding for integers is used.</li>
  * <li>Output serialized using this class should always be deserilized using @link{UnsafeMemoryInput}</li>
  * 
@@ -132,8 +132,9 @@ final public void writeBoolean (boolean value) throws KryoException {
 
 	/** Writes a 2 byte char. */
 	final public void writeChar (char value) throws KryoException {
-		super.niobuffer.position(position);
-		super.writeChar(value);
+		require(2);
+		unsafe().putChar(bufaddress + position, value);
+		position += 2;
 	}
 
 	/** Writes an 8 byte double. */
diff --git a/src/com/esotericsoftware/kryo/io/UnsafeOutput.java b/src/com/esotericsoftware/kryo/io/UnsafeOutput.java
@@ -19,7 +19,7 @@
  * Important notes:<br/>
  * <li>This class increases performance, but may result in bigger size of serialized representation.</li>
  * <li>Bulk operations, e.g. on arrays of primitive types, are always using native byte order.</li>
- * <li>Fixed-size int, long, short, float and double elements are always written using native byte order.</li>
+ * <li>Fixed-size char, int, long, short, float and double elements are always written using native byte order.</li>
  * <li>Best performance is achieved if no variable length encoding for integers is used.</li>
  * <li>Output serialized using this class should always be deserilized using @link{UnsafeInput}</li>
  * 
@@ -124,6 +124,13 @@ final public void writeDouble (double value) throws KryoException {
 		position += 8;
 	}
 
+	/** Writes a 2 byte char. */
+	final public void writeChar (char value) throws KryoException {
+		require(2);
+		unsafe().putChar(buffer, byteArrayBaseOffset + position, value);
+		position += 2;
+	}
+
 	final public int writeInt (int value, boolean optimizePositive) throws KryoException {
 		if (!supportVarInts) {
 			writeInt(value);
