Fix compile warning and add high DPI support#200
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a compilation warning (CA1824) and implements high DPI support for the SQLQueryStress application. The changes ensure better display quality on high-resolution monitors and eliminate a code analysis warning.
- Fixed CA1824 warning by adding NeutralLanguage property
- Enabled high DPI scaling with PerMonitorV2 support
- Updated documentation to reflect native high DPI support
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/SQLQueryStress/SQLQueryStress.csproj | Added NeutralLanguage property to resolve CA1824 warning |
| src/SQLQueryStress/Properties/app.manifest | Configured DPI awareness settings in application manifest |
| src/SQLQueryStress/Program.cs | Set high DPI mode in application startup |
| README.md | Updated documentation to indicate native high DPI support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @ErikEJ, since adding High DPI support, the buttons on the right panel have increased in size, making the input box on the left feel a bit cramped. Would you mind if I increased the default window width to 1300px? It balances the layout much better. If you're okay with that, I can include an additional commit with the adjustment. |
|
Seems ok to increase width these days |
|
Just remove the paragraph in the readme, older versions are not supported |
|
Done |
|
LGTM - possible to share a high DPI screen shot? |
|
Sure. With the high DPI support added, the application displays perfectly right out of the box. Without any additional configuration, the UI elements render at appropriate sizes—fonts are readable, buttons are properly scaled, and the overall appearance just feels right. There are no issues with undersized fonts or tiny buttons; everything displays correctly by default. 
Btw, I use the following command to compile the project into a single executable file. |
|
Very cool! I do the same in my pipeline here: https://github.com/ErikEJ/SqlQueryStress/blob/master/.github%2Fworkflows%2Fdotnet.yml#L38 |
|
But maybe I can avoid the .zip step and just publish the .exe?? |
|
@0x7FFFFFFFFFFFFFFF Thanks! |
IMO, that would be better! |
|
Agree, already asked Copilot to work on it |
Fix compile warning and add high DPI support