Use correct params for MessageBox.Show(); fix typos#162
Merged
ErikEJ merged 1 commit intoErikEJ:masterfrom Oct 8, 2024
mikeblas:titles
Merged
Use correct params for MessageBox.Show(); fix typos#162ErikEJ merged 1 commit intoErikEJ:masterfrom mikeblas:titles
ErikEJ merged 1 commit intoErikEJ:masterfrom
mikeblas:titles
Conversation
This checkin adds titles to message boxes, which were previously blank. A message box title should identify the app which created the message box. A couple of MessgaeBox calls incorrectly used the title parameter for parts of the message. Also fixes a couple of typos while driving by.
Owner
|
@mikeblas Thanks, I wish these changes could be made without all the designer changes, it is a nightmare to review what the actual changes are |
Owner
|
@mikeblas Thanks for your contribution! |
Contributor
Author
|
Yeah, I noticed that. Is there a way to do so? I just added one string so that the name of the app could be localized, if ever needed. ("Le SqlQueryStress" vs "Du SqlQueryStress", or something. LOL.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checkin adds titles to message boxes, which were previously blank. A message box title should identify the app which created the message box.
A couple of
MessageBoxcalls incorrectly used the title parameter for parts of the message.Also fixes a couple of typos while driving by.
See issue #161, which identifies the problem with un-titled message boxes.