Expand user in the CodeChecker binary path#98
Merged
Discookie merged 1 commit intoEricsson:mainfrom Feb 28, 2022
Merged
Conversation
Discookie
requested changes
Feb 28, 2022
Collaborator
Discookie
left a comment
Discookie
left a comment
There was a problem hiding this comment.
One small thing, otherwise LGTM!
I would've preferred a library for this, but for this simple one it's good enough.
|
|
||
| // Expand an initial '~' component in the given path if there is any, otherwise returns the file path without changes. | ||
| function expandUser(filePath: string) { | ||
| return os.homedir ? filePath.replace(/^~(?=$|\/|\\)/, os.homedir) : filePath; |
Collaborator
There was a problem hiding this comment.
os.homedir is a function, not a string.
Technically it still works because .replace() accepts a (...) => string as second argument, but it'll fail on systems with no homedir.
We are using `spawn` method to execute a CodeChecker command. If the executable path starts with a `~` (e.g.: `~/CodeChecker/bin/CodeChecker`), the `spawn` method doesn't work properly and will give an exception. For more information see: nodejs/node#684 To solve this problem we will expand the `~` in the file path before executing the command.
csordasmarton
force-pushed
the
cc_path_expand_user
branch
from
d8017f4 to
a4bd18e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using
spawnmethod to execute a CodeChecker command.If the executable path starts with a
~(e.g.:~/CodeChecker/bin/CodeChecker),the
spawnmethod doesn't work properly and will give an exception.For more information see: nodejs/node#684
To solve this problem we will expand the
~in the file path beforeexecuting the command.