Fix showing diagnostics in the Problems pane#70
Merged
Discookie merged 1 commit intoEricsson:mainfrom Feb 14, 2022
Merged
Conversation
Discookie
requested changes
Feb 2, 2022
Collaborator
Discookie
left a comment
Discookie
left a comment
There was a problem hiding this comment.
There's a couple things broken by this change:
- The reproduction steps are now invisible in the editor, other than the CodeLens header. Makes it much harder to see eg. when there's multiple statements on the same line, or when only a certain parameter is of interest. (CodeChecker web highlights the steps in yellow.)
- Reproduction steps are always shown in the Problems tab, so when the user clicks on a non-active repr. step, and the step is in a different file, the entire bug disappears.
- There's now a considerable amount of duplicate information between the Reports tab and the Problems list, but with the Problems list having worse functionality.
- Since keyboard navigation is based on the repr. steps' ranges, it becomes very unintuitive as well since the user won't be able to find the range where the navigation works.
- Small nitpick is that the report's description always contains a link to itself as the last step.
My recommendation would be to have the steps displayed only under the active report, but still have the individual steps be displayed as Information ranges.
Another thing is using the other diagnostic severities for different kinds of reports, so that Low severity can become a warning instead of an error, and so on.
- Show reports as separate diagnostic items and show bug steps as diagnostic related information. - Show different severities based on the CodeChecker severity level. - Refactoring the code.
csordasmarton
force-pushed
the
fix_diagnostics_in_problems_panel
branch
from
6781ad8 to
425894f
Compare
Contributor
Author
|
As we discussed this on a meeting we will remove bug steps from the Problems pane and I created an issue (#88) to highlight bug step ranges in the editor different way if it's supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related information.
Screenshot:
