Reduce number of parse calls#58
Merged
csordasmarton merged 1 commit intoEricsson:mainfrom Jan 31, 2022
Merged
Conversation
csordasmarton
suggested changes
Jan 28, 2022
Comment on lines
+81
to
+82
| const dummyData: ParseResult = { reports: [], version: 1 }; | ||
| this.parseDiagnosticsData(JSON.stringify(dummyData)); |
Contributor
There was a problem hiding this comment.
I don't really like this approach that we are creating a dummy data only to call this function. Why do we need to call parseDiagnosticsData here? To initialize this._diagnosticEntries and other variables? In this case we can initialize these fields here too. Also if it contains some extra logic we can create a separate function for it and we can call it here and in the parseDiagnosticsData function.
Collaborator
Author
There was a problem hiding this comment.
Moved the field initializations here.
The parseMetadata does a little bit of extra processing when deciding whether this._selectedEntry should be kept, but selectedEntry cannot exist inside the unloading if, so it's no concern here.
Discookie
force-pushed
the
ericsson/fix-double-parse
branch
from
5b250e8 to
c95cb6d
Compare
Does not call parse: * When open files did not change * When there's no files open * When an opened window is an 'output://' window
Discookie
force-pushed
the
ericsson/fix-double-parse
branch
from
c95cb6d to
2421b52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39.
The extension no longer executes a parse call when: