Update dependencies and fix Yarn 2 enable bug#140
Merged
vodorok merged 3 commits intoEricsson:mainfrom Apr 10, 2024
Merged
Conversation
Discookie
force-pushed
the
ericsson/fix-ci
branch
from
1f5816f to
3515f05
Compare
vodorok
requested changes
Apr 9, 2024
Collaborator
vodorok
left a comment
vodorok
left a comment
There was a problem hiding this comment.
I would put the Yarn 2 uplift related changes into a different commit .
| await assert.rejects( | ||
| () => parseMetadata(path.join(staticPath, filename)), | ||
| (err) => { | ||
| (err: MetadataParseError) => { |
Collaborator
There was a problem hiding this comment.
Shouldn't you use the MetadataParseError in the next test case too?
Collaborator
Author
There was a problem hiding this comment.
This change was just to silence a TS type-error because it couldn't deduce the error type of parseMetadata.
Might as well use the type on the next case as well, fixed.
* A recent change requires that Corepack is enabled on the system if we want to interact with Yarn 1 at all, even if that is just to enable Yarn 2+.
Discookie
force-pushed
the
ericsson/fix-ci
branch
from
3515f05 to
eef200f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates yarn to 4.1.0, dependencies to latest available, fixes nodejs update-related issues, and fix enabling Yarn Stable in CI.