Migrate to Yarn 2+ and bump dependencies#123
Merged
Discookie merged 2 commits intoEricsson:mainfrom Mar 17, 2023
Merged
Conversation
Probably a Yarn 2 issue.
This was referenced Mar 16, 2023
vodorok
approved these changes
Mar 17, 2023
Collaborator
vodorok
left a comment
vodorok
left a comment
There was a problem hiding this comment.
LGTM apart from one question.
| import * as fs from 'fs'; | ||
|
|
||
| import { runTests } from 'vscode-test'; | ||
| import { runTests } from '@vscode/test-electron'; |
Collaborator
There was a problem hiding this comment.
Just a question, is this related to the Yarn2 upgrade?
Collaborator
Author
There was a problem hiding this comment.
The package was apparently migrated it to a different namespace, and the old repository is now deprecated. Same happened with vsce => @vscode/vsce. Yarn gave warnings about the old ones.
Collaborator
Author
There was a problem hiding this comment.
(This was a general issue, not a Yarn 2-specific one)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the build seems to fail on CI because of an outdated webpack using an outdated OpenSSL version.
Updated ESLint dependencies, and using Yarn 2 lockfiles now.