Notifications overhaul#116
Merged
vodorok merged 5 commits intoEricsson:mainfrom Dec 9, 2022
Merged
Conversation
Collaborator
Discookie
commented
Sep 8, 2022
Discookie
commented
- Added a sidebar view to show past notifications
- The notif's actions can still be executed through the sidebar, even if the user disabled pop-up notifications
- Ported all existing notifications to the new system, but did not add any new ones yet
* Add support for updating previous notifications
Collaborator
Author
|
Refactored the notifications system, to support updating previously-added notifications. |
vodorok
reviewed
Nov 25, 2022
Collaborator
vodorok
left a comment
vodorok
left a comment
There was a problem hiding this comment.
Looks good to me, but I need to test it before merging.
Do you have ideas to test this feature?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.