Improvements for handling CodeChecker version checks#114
Improvements for handling CodeChecker version checks#114vodorok merged 2 commits intoEricsson:mainfrom
Conversation
* This prevents killing off a version check in the queue, showing a bogus error message
vodorok
left a comment
vodorok
left a comment
There was a problem hiding this comment.
Please see my only remark, otherwise good job!
| this.statusBarItem.text = '$(testing-error-icon) CodeChecker: analysis errored'; | ||
| window.showErrorMessage('CodeChecker finished with error - see logs for details'); | ||
|
|
||
| const shouldShowError = workspace.getConfiguration('codechecker.executor') |
There was a problem hiding this comment.
I wouldn't hide Codechecker runtime error notifications in the case when the user ticks the newly introduced option. The settings description says: "Enable notifications when CodeChecker is not found or not supported", but I suspect there can be other errors too. Partial/total suppression of notifications could be introduced, like with a slider or with another tickbox, that says, "Disable every popup originating from the plugin" or something along the way.
If the cases for a failed analysis and other runtime errors are handled elsewhere than this, please consider the above remarks irrelevant.
There was a problem hiding this comment.
Changed the option to Enable CodeChecker-related notifications, as other notifications being spammed has also been an issue before. It now controls every notification, except when a report cannot be found when trying to jump to it.
I'm planning to show the notification's contents in the sidebar, but that will be added in another PR.
Discookie
force-pushed
the
ericsson/fix-killed-version-check
branch
from
961ff85 to
a5af626
Compare
Discookie
force-pushed
the
ericsson/fix-killed-version-check
branch
from
a5af626 to
04ddd49
Compare
2 participants
Fixes #111.
CodeChecker versionhandling, so a version check process couldn't be prematurely killed, leading to a falseCodeChecker not foundnotification. (Should be enough to fix the particular issue showing double notifs.)