Refactor report tree#112
Merged
vodorok merged 2 commits intoEricsson:mainfrom Jul 29, 2022
Merged
Conversation
- Refactore the report tree's code. - Display depth of report steps. - Group reports by severity levels.
This was referenced Jul 8, 2022
Closed
vodorok
approved these changes
Jul 28, 2022
Collaborator
vodorok
left a comment
vodorok
left a comment
There was a problem hiding this comment.
Looks good to me, nicely done.
I have one design idea: When clicking the View Problem of an issues' right hover context, and the REPORTS IN CURRENT FILE view is expanded, we could navigate to the clicked report in the tree. I would like some kind of a two-way binding, as there are are a lot of functionality in the treeview, but the user has to search for the report to be able to use them.
|
|
||
| constructor(ctx: ExtensionContext) { | ||
| ctx.subscriptions.push(this._diagnosticsUpdated = new EventEmitter()); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59, closes #40, supersedes and closes #107.
Fixed my comments in #107.