Skip to content

Support for PureBasic language #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndiDittrich merged 2 commits into from
Apr 19, 2020
Merged

Support for PureBasic language #96

AndiDittrich merged 2 commits into from
Apr 19, 2020

Conversation

@gphilippot
Copy link
Contributor

@gphilippot gphilippot commented Apr 15, 2020

Added rules for the PureBasic language.
Added a purebasic entry to the index.js

Screenshot
image

@gphilippot
Support for PureBasic language
1ba1c78 
Added rules for the PureBasic language.
Added a purebasic entry to the index.js
@AndiDittrich
Copy link
Member

AndiDittrich commented Apr 16, 2020

Hi @gphilippot ,

thanks for your contribution. please fix the following issues - otherwise i cannot merge it:

  • CI checks failed (lint)
  • Your regex using lookbehind and lookahead groups, these are not supported by all modern browser so please remove them
  • the arithemtic operator regex and some other are quite complex, suggest to split them into multiple rules

@AndiDittrich AndiDittrich merged commit f6354f8 into EnlighterJS:master Apr 19, 2020
@AndiDittrich
Copy link
Member

AndiDittrich commented Apr 19, 2020

great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

EnlighterJS3 FeatureRequest upcoming feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gphilippot @AndiDittrich