Add "Autoplay Speed" field to Slick Slider-based elements#87
Merged
andrew-worsfold merged 3 commits intoEnclavely:masterfrom Jan 30, 2017
Merged
Add "Autoplay Speed" field to Slick Slider-based elements#87andrew-worsfold merged 3 commits intoEnclavely:masterfrom
andrew-worsfold merged 3 commits intoEnclavely:masterfrom
Conversation
…ements
Added “Autoplay Speed” field to all Slick Slider-based elements:
- Carousel
- Gallery (Carousel and Slideshow layout)
- Posts (Carousel layout)
“Autoplay Speed” field is displayed conditionally when “Autoplay” is
set to “on”.
“Autoplay Speed” is in milliseconds.
Contributor
Author
|
Came across a possible bug in production where when Tailoring the page (Customizer) the slide speed is set as undefined (0ms), investigating further. |
Contributor
Author
|
Fixed the issue. 🤦♂️ |
Contributor
|
Thanks for the effort here, @gnowland! Much appreciated! |
Contributor
Author
|
Glad to help @andrew-worsfold -- fantastic plugin, I hope to contribute more pull requests in the future! |
andrew-worsfold
referenced
this pull request
Mar 16, 2017
* Added - Instant undo/redo functionality with keyboard controls. * Added - Portuguese translation [GitHub 93](https://github.com/andrew-worsfold/tailor/pull/93). * Added - Autoplay speed setting to carousel and slideshow-based layouts [GitHub 87](https://github.com/andrew-worsfold/tailor/pull/87). * Improved - Allow unlimited images in Gallery elements [GitHub 86](https://github.com/andrew-worsfold/tailor/pull/86). * Improved - Sidebar styles to match the Customizer. * Changed - Default placeholder text for Content elements. * Fixed - tailor_get_users() query retrieves unnecessary information [GitHub 94](https://github.com/andrew-worsfold/tailor/pull/94). * Fixed - Sidebar styles affecting search field within WordPress Media Modal [GitHub 98](https://github.com/andrew-worsfold/tailor/issues/98).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Andrew,
I’ve added an input field to adjust the slide "pause" duration for all Slick Slider-based elements:
“Autoplay Speed” field is displayed conditionally when "Autoplay" is set to
on. "Autoplay Speed" is in milliseconds.I wasn’t sure what your preferred PR process was because I couldn’t find any contributing guidelines, so I only committed un-compiled (src) files… if you need anything else let me know.
Great project, very clean codebase — I hope to commit more in the future! 🙂