Prevent error if get_current_screen() not defined#74
Merged
andrew-worsfold merged 1 commit intoEnclavely:masterfrom Nov 19, 2016
Merged
Prevent error if get_current_screen() not defined#74andrew-worsfold merged 1 commit intoEnclavely:masterfrom
andrew-worsfold merged 1 commit intoEnclavely:masterfrom
Conversation
Per the WordPress Codex: get_current_screen() is defined on most admin pages, but not all. Thus there are cases where is_admin() will return true, but attempting to call get_current_screen() will result in a fatal error because it is not defined... Checking that the function exists before calling it allows us to avoid the error, but we can no longer be sure that we are editing a post or page and can only assume that we are not.
Contributor
|
Thanks for this, @magoyo! |
andrew-worsfold
referenced
this pull request
Nov 27, 2016
* Added - Element label when hovering over an element in the preview window. * Improved - Columns now use percentage widths, instead of a 12 column grid system. * Improved - Up to six columns can now be added to a single row instead of four (and of course you can still nest rows). * Improved - Background image parallax effect [GitHub 60](https://github.com/andrew-worsfold/tailor/issues/60). * Improved - Dynamic element CSS rules now supports SCSS-like syntax (e.g., :, :: and & special characters); * Fixed - General color settings appear in the Tailor colors Customizer section for some themes [GitHub 73](https://github.com/andrew-worsfold/tailor/issues/73). * Fixed - An error message is displayed if get_current_screen() is not defined [GitHub PR 74](https://github.com/andrew-worsfold/tailor/pull/74). * Fixed - Elements are loaded too early, causing an issue with the New User Approve plugin [GitHub 75](https://github.com/andrew-worsfold/tailor/issues/75). * Fixed - Graphic color not being displayed correctly when upgrading from early versions of Tailor. * Fixed - Some units (for example "vw" and "vh" when setting minimum width and height) not being accepted in preview. * Fixed - Masonry-enabled elements do not refresh when their parent element changes. * Removed - Maximum 75rem width (CSS property) for Section content (use maximum width setting instead, if required).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a conflict with another plugin (Carbon Fields) that caused a fatal error because get_current_screen() was not defined when attempting to add the edit link above content editor. I did further research and found that, per the WordPress Codex, get_current_screen() is defined on most admin pages, but not all. Thus there are cases where is_admin() will return true, but attempting to call get_current_screen() will result in a fatal error because it is not defined... Checking that the function exists before calling it allows us to avoid this error in general, but we can no longer be sure that we are editing a post or page and can only assume that we are not.