Prevent null matches on widgets control change. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have steps to reproduce the issue? What sort of error is being thrown? |
|
I investigated a little bit more why I got this error: This is due to a conflict with the plugin "Custom sidebars" from the authors WPMU DEV: |
andrew-worsfold
added a commit
that referenced
this pull request
Oct 12, 2016
Improved - Reduced the amount of layout meta information saved to the post, the selector for element child containers can now be specified when registering the element. Fixed - Live updates to Button do not target correct DOM node [GitHub #50](https://github.com/andrew-worsfold/tailor/issues/50), cannot add multiple custom class names to an element [GitHub PR #51](https://github.com/andrew-worsfold/tailor/pull/51), fields added to the widget form by third-party plugins are not handled correctly [GitHub PR #52](https://github.com/andrew-worsfold/tailor/pull/52).
ManUtopiK
added a commit
to ManUtopiK/tailor
that referenced
this pull request
Oct 13, 2016
…to Fix-widgets-controlChange * 'master' of https://github.com/andrew-worsfold/tailor: Tailor 1.6.2. Fixed - Copy history entry created when copying using the Copy button. Tailor 1.6.2. Added - "Copy" button to elements. Tailor 1.6.1. Improved - Reduced the amount of layout meta information saved to the post, the selector for element child containers can now be specified when registering the element. Fixed - Live updates to Button do not target correct DOM node [GitHub Enclavely#50](https://github.com/andrew-worsfold/tailor/issues/50), cannot add multiple custom class names to an element [GitHub PR Enclavely#51](https://github.com/andrew-worsfold/tailor/pull/51), fields added to the widget form by third-party plugins are not handled correctly [GitHub PR Enclavely#52](https://github.com/andrew-worsfold/tailor/pull/52). Prevent null matches. (Enclavely#52) Allow multiple class on attribute class name. Prevent multiple whitespace and whitespace and the end of string; (Enclavely#51) # Conflicts: # assets/js/dist/sidebar.js # assets/js/src/sidebar/components/controls/widget-form.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this cool new widgets feature!
I got some bugs when I change any input that throw an error on control change.
This is a quick fix but I'm not sure it's well integrated wuth all the process...