Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailor Editing overwrites WP Editor edited content #41

Open
diogocsc opened this issue Sep 30, 2016 · 7 comments
Open

Tailor Editing overwrites WP Editor edited content #41

diogocsc opened this issue Sep 30, 2016 · 7 comments

Comments

@diogocsc
Copy link

diogocsc commented Sep 30, 2016

A client has been recurrently editing content on main WP page, and after editing content in Tailor, all changes on WP Edit page are lost.
I've explained it often but it seems they are having hard time to learn.
Fortunately WP has a "revisions" option to recover content.

A way to do this would be to migrate changes in WP Editor to Tailor? (and remove the message: "Changes made to this página within the editor will not be displayed in Tailor")
Or maybe some way of disabling the content area within the WP Edit screen when using Tailor for a page?

Thanks

@ManUtopiK
Copy link
Contributor

ManUtopiK commented Sep 30, 2016

I got similar problems with some clients. So I made a BIG message on the edit page screen to explain more how is the process with Tailor. But to display a big message, I needed some html markup. It's why I did this pull request #38.

But maybe wp_editor should be completely hidden or hidden with an overlay and the message above.

@diogocsc diogocsc changed the title Migrate WP Editor content to Tailor Tailor Editing overwrites WP Editor content Sep 30, 2016
@diogocsc diogocsc changed the title Tailor Editing overwrites WP Editor content Tailor Editing overwrites WP Editor edited content Sep 30, 2016
@andrew-worsfold
Copy link
Contributor

@diogocsc -

The challenge here is that the post content (which is just simple HTML) lacks information about the layout, which is stored separately in post meta. Translating changes made within the editor into the Tailor layout is therefore no easy task.

Disabling the editor is certainly possible, but must be done carefully.

@diogocsc, @ManUtopiK -

The reason for having the editor both visible and accessible is to prevent users from being locked out of making simple content changes after having "Tailored" a post or page. Although I am still extremely hesitant to block people from core WordPress functionality (like editing posts), I understand where you are coming from here and recognise that for some developer/customer relationships this may be the best option.

I'm thinking we could have this be something that people "opt-in" to on the Settings page (but also allow developers to filter the default setting so people in your situation don't need to necessarily educate users on the topic). I see @diogocsc has made this recommendation in one of the related issues.

Happy to explore options here. Does anyone have any code we could use as a starting point for this?

@diogocsc
Copy link
Author

diogocsc commented Oct 3, 2016

@andrew-worsfold, what do you mean by enhancement? After changing a toggle content area in WP Editor and then Edited throught Tailor, WP edit is overwriten.

As for code, maybe this is a good starting point ? : https://gist.github.com/atomtigerzoo/0dd49ed9ca67ec111465 ?

@ThiagoAlbergoni
Copy link

Hello Andrew, can you please help me with Tailor problem?
I'm getting this message when I'm editing a page from my WP:
'' Changes made to this page within the publisher will not be displayed in Tailor. Delete layout ''
What does that mean?
I click to close it, but she insists on appearing again, what happens if I delete the layout?
Please help me.

@andrew-worsfold
Copy link
Contributor

Hi @ThiagoAlbergoni -

Tailor stores information about the layout of the page as meta data and saves the resulting HTML as post content. This way the content is just that, content, and doesn't need to be processed during a page load (there are other reasons too, which I won't get in to).

The message that you're referring to simply means that if you edit the actual post content in the editor, that's what you'll see on the front end but it will differ from the stored layout information. The next time you launch Tailor, it will use the stored layout information to build the preview (which will differ from the saved content).

I hope that makes sense.

Cheers,
Andrew.

@ThiagoAlbergoni
Copy link

ThiagoAlbergoni commented Feb 6, 2017 via email

@hustlelikeaboss
Copy link

Has this been fixed? Looks like the content (mostly text) that I added directly inside the WordPress editor is preserved in Tailor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants