Skip to content

Commit ed73bc0

Browse files
[verified] fix(desktop): align Thread Rail panel height
Signed-off-by: Empire Operating <[email protected]>
1 parent 0fbd0e8 commit ed73bc0

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎desktop/src/features/channels/threadRailLayout.test.mjs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,21 +30,21 @@ test("Thread Rail column replaces exposed sidebar paint without adding corners",
3030
assert.doesNotMatch(className, /ring/);
3131
});
3232

33-
test("Thread Rail paints a compact rounded card capped at the content bounds", () => {
33+
test("Thread Rail paints one full-height rounded panel inside the unframed column", () => {
3434
for (const collapsed of [false, true]) {
3535
const className = threadRailShellClassName(collapsed);
3636

3737
assert.match(className, /mt-px/);
3838
assert.match(className, /mb-2/);
39-
assert.match(className, /max-h-\[calc\(100%-0\.5625rem\)\]/);
39+
assert.match(className, /(?<!max-)h-\[calc\(100%-0\.5625rem\)\]/);
4040
assert.match(className, /self-start/);
4141
assert.match(className, /rounded-2xl/);
4242
assert.match(className, /overflow-hidden/);
4343
assert.match(className, /bg-background(?!\/)/);
4444
assert.match(className, /shadow-content-edge/);
4545
assert.match(className, /ring-border\/30/);
4646
assert.match(className, /ring-inset/);
47-
assert.doesNotMatch(className, /(?<!max-)h-\[calc\(100%-0\.5625rem\)\]/);
47+
assert.doesNotMatch(className, /max-h-\[calc\(100%-0\.5625rem\)\]/);
4848
assert.doesNotMatch(className, /clip-path/);
4949
assert.doesNotMatch(className, /self-stretch/);
5050
assert.doesNotMatch(className, /\bmy-2\b/);

‎desktop/src/features/channels/threadRailLayout.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export function threadRailColumnClassName(): string {
66

77
export function threadRailShellClassName(_collapsed: boolean): string {
88
return [
9-
"hidden mb-2 mr-2 mt-px max-h-[calc(100%-0.5625rem)] min-h-0 shrink-0 self-start overflow-hidden rounded-2xl bg-background shadow-content-edge ring-1 ring-border/30 ring-inset",
9+
"hidden mb-2 mr-2 mt-px h-[calc(100%-0.5625rem)] min-h-0 shrink-0 self-start overflow-hidden rounded-2xl bg-background shadow-content-edge ring-1 ring-border/30 ring-inset",
1010
"min-[601px]:flex min-[601px]:flex-col",
1111
].join(" ");
1212
}

‎desktop/tests/e2e/thread-rail.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ test("pins a canonical thread, switches it from the collapsible rail, and unpins
9494
railRadius: paneGeometry.contentRadius,
9595
railBackground: paneGeometry.contentBackground,
9696
});
97-
expect(paneGeometry.railBottom).toBeLessThan(paneGeometry.contentBottom);
97+
expect(paneGeometry.railBottom).toBe(paneGeometry.contentBottom);
9898
expect(paneGeometry.railColumnRadius).toBe("0px");
9999
expect(paneGeometry.railColumnBackgroundImage).toContain("linear-gradient");
100100
expect(paneGeometry.railClipPath).toBe("none");

0 commit comments

Comments
 (0)