Repository navigation
Add struct-backed extension type cases for CASE in metadata.slt - #186
Open
raghuvanshraj wants to merge 1 commit into
Open
raghuvanshraj wants to merge 1 commit into
raghuvanshraj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the struct-backed extension type cases for CASE to
metadata.slt, as discussed on apache#26145.The branches are
named_struct(...)values tagged withARROW:extension:name, the shape Parquet Variant has.arrow_metadata()on a CASE only sees the executed field, so the logical field is observed through the planning error of an outercoalesce, the same way the existing coalesce cases do it.All cases pass on this branch. On
mainthe threestatement errorcases succeed instead, because the tag is dropped.