Skip to content

Fix missing header after make install #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichalPrincNXP merged 1 commit into from
May 16, 2025
Merged

Fix missing header after make install #447

MichalPrincNXP merged 1 commit into from
May 16, 2025

Conversation

@ddassie-texa
Copy link
Contributor

@ddassie-texa ddassie-texa commented Jan 15, 2025

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

This PR fixes the erpc_c Makefile, the erpc_simple_server.hpp header was never installed.

To Reproduce

Compile the library with make, than try to install it with make install, the erpc_simple_server.hpp file won't be copied to the include directory.

Expected behavior

erpc_simple_server.hpp should be installed and available to consumers.

Desktop (please complete the following information):

  • OS: Linux Ubuntu 24.04 x86_64, Linux Yocto (multiple architectures)
  • eRPC Version: v1.13.0

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.
  • Allow edits from maintainers pull request option is set (recommended).

@MichalPrincNXP MichalPrincNXP changed the base branch from develop to main May 16, 2025 08:15
@MichalPrincNXP MichalPrincNXP merged commit 88869ae into EmbeddedRPC:main May 16, 2025
2 checks passed
@MichalPrincNXP
Copy link
Member

MichalPrincNXP commented May 16, 2025

Thanks for the effort.

ahyros pushed a commit to ahyros/erpc that referenced this pull request Aug 25, 2025
@ddassie-texa @ahyros
fix(Makefile): install the erpc_simple_server header (EmbeddedRPC#447)
9016527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichalPrincNXP MichalPrincNXP MichalPrincNXP approved these changes

@Hadatko Hadatko Hadatko approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddassie-texa @MichalPrincNXP @Hadatko