check the buffer boundaries before reading from heap #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amgross
changed the title
Hadatko
approved these changes
Jul 1, 2022
Member
Hadatko
left a comment
Hadatko
left a comment
There was a problem hiding this comment.
I think * sizeof({$info.mallocSizeType}) is redudant. Binary type will be always one byte and maxSize is just number anyway.
Member
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Choose Correct
Describe the pull request
Check that length that going to read from heap buffer that was allocated by the auto-generated code not exceeding the buffer length
To Reproduce
Attached example code (.erpc):
min_reproduce.txt
reproduces (cpp code):
min_reproduce_server.txt
I recommend to add similar use case to tests, as currently I didn't find similar tests
to make the assert pop, return ret_size bigger than 100
Expected behavior
Stuck (at least at dev flavors), probably heap corrupted
Screenshots
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context
Not sure if to add enter between the assert to the write