Skip to content

Conversation

@Hadatko
Copy link
Member

@Hadatko Hadatko commented Oct 8, 2020

-- Code style of document was confusing.
-- Added link to documentation for current version.

-- Code style of document was confusing.
-- Added link to documentation for current version.
@Hadatko Hadatko added the bug label Oct 8, 2020
@Hadatko Hadatko requested a review from MichalPrincNXP October 8, 2020 13:04
@Hadatko Hadatko self-assigned this Oct 8, 2020
@Hadatko
Copy link
Member Author

Hadatko commented Oct 8, 2020

Any plans to move to the newer clang-format?

@MichalPrincNXP
Copy link
Member

Any plans to move to the newer clang-format?

It would be fine, let me try to format with clang V10 and test it internally. Once OK, I would switch to this V10 version.

Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@MichalPrincNXP MichalPrincNXP merged commit 3ee6898 into EmbeddedRPC:develop Oct 9, 2020
@MichalPrincNXP
Copy link
Member

Any plans to move to the newer clang-format?

It would be fine, let me try to format with clang V10 and test it internally. Once OK, I would switch to this V10 version.

@Hadatko , testing with Clang V10 formatted code is OK, we can use it, I will provide an update early next week together with other changes for 1.8.0 release.

@Hadatko Hadatko deleted the fix_clang_formatter branch October 9, 2020 10:56
@Hadatko
Copy link
Member Author

Hadatko commented Oct 9, 2020

Do not forget update wiki, run_clang_format.py, and current new yaml which should format code automatically. Hope it will work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants