chore: remove rustfmt check in configure #8540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
king-11
force-pushed
the
king-11/remove-rustfmt
branch
from
5505200 to
ea9c76a
Compare
Contributor
|
I came across this today on my node: it seems rustfmt is deprecated (Ubuntu 24.04) so |
rustyrussell
force-pushed
the
king-11/remove-rustfmt
branch
from
3e54b4d to
b4c073e
Compare
rustfmt isn’t needed for production builds and cargo is sufficient [ Also, rustfmt --version exits with status 1 due to deprecation --RR ] Changelog-None
rustyrussell
force-pushed
the
king-11/remove-rustfmt
branch
from
b4c073e to
182e958
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
25.12 FREEZE October 27th: Non-bugfix PRs not ready by this date will wait for 26.03.
RC1 is scheduled on November 10th
The final release is scheduled for December 1st.
rustfmt isn’t needed for production builds and cargo is sufficient
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: