Skip to content

jsn/signet fix #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsarenik wants to merge 2 commits into from
Closed

jsn/signet fix #4073

jsarenik wants to merge 2 commits into from

Conversation

@jsarenik
Copy link
Contributor

@jsarenik jsarenik commented Sep 22, 2020

Just a rebased #4068 with one more fix in a comment. Making this PR to see if Travis is happy after rebase.

@jsarenik jsarenik changed the title Jsn/signet fix jsn/signet fix Sep 22, 2020
@jsarenik
Copy link
Contributor Author

jsarenik commented Sep 22, 2020

There is some issue. I can repeatedly get this, while no such error occurs on master(a08e835)

$ make check
lightningd: WARNING: default network changing in 2020: please set network=testnet in config!
bitcoin/test/run-tx-encode > /dev/null
bitcoin/test/run-bitcoin_block_from_hex > /dev/null
bitcoin/test/run-secret_eq_consttime > /dev/null
run-secret_eq_consttime: Load 3.47: too high, ignoring
common/test/run-key_derive > /dev/null
common/test/run-json > /dev/null
do_json_tok_bitcoin_amount("0.00000001", 1): ok
do_json_tok_bitcoin_amount("0.00000007", 7): ok
do_json_tok_bitcoin_amount("0.00000008", 8): ok
do_json_tok_bitcoin_amount("0.00000010", 10): ok
do_json_tok_bitcoin_amount("0.12345678", 12345678): ok
do_json_tok_bitcoin_amount("0.01234567", 1234567): ok
do_json_tok_bitcoin_amount("123.45678900", 12345678900): ok
common/test/run-softref > /dev/null
common/test/run-cryptomsg > /dev/null
common/test/run-bolt11 > /dev/null
run-bolt11: common/test/run-bolt11.c:65: test_b11: Assertion `b11->chain == expect_b11->chain' failed.
Aborted
make: *** [Makefile:527: unittest/common/test/run-bolt11] Error 134

Investigating… will update here when I know more.

@jsarenik jsarenik closed this Sep 22, 2020
@jsarenik
Copy link
Contributor Author

jsarenik commented Sep 22, 2020

When I do this, the error disappears:

diff --git a/bitcoin/chainparams.c b/bitcoin/chainparams.c
index 7e0501271..de995ad06 100644
--- a/bitcoin/chainparams.c
+++ b/bitcoin/chainparams.c
@@ -80,7 +80,7 @@ const struct chainparams networks[] = {
 			   .bip32_privkey_version = BIP32_VER_TEST_PRIVATE},
      .is_elements = false},
     {.network_name = "signet",
-     .bip173_name = "tb",
+     .bip173_name = "sb",
      .bip70_name = "signet",
      // 00000008819873e925422c1ff0f99f7cc9bbb232af63a077a480a3633bee1ef6
      .genesis_blockhash = {{{.u.u8 = {0xf6, 0x1e, 0xee, 0x3b, 0x63, 0xa3, 0x80,

@jsarenik
Copy link
Contributor Author

jsarenik commented Sep 22, 2020

So there seems to be some collision.

@jsarenik jsarenik mentioned this pull request Sep 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsarenik @dr-orlovsky