getnewblockhex: Take data push for arbitrary data in block coinbase c… #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
force-pushed
the
getnewblockhex_commit
branch
from
b9ebab3 to
98a1547
Compare
stevenroose
reviewed
Oct 24, 2019
src/rpc/mining.cpp
Outdated
| }, | ||
| }, | ||
| "proposed_parameters"}, | ||
| {"data", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "Data in hex to be committed to in an additional coinbase output."}, |
Contributor
Author
There was a problem hiding this comment.
that's not a nit :) will fix
Contributor
Author
There was a problem hiding this comment.
oh I see, you're nitting the name. I'm merely matching what's in createrawtransaction fwiw, so I'll keep this if that's ok
Contributor
There was a problem hiding this comment.
I was nitting the name. In createrawtx, the data field is part of an output. Here it's part of a block. I think it's less obvious what "data" means in a "create block" context. But well if you think consistency is more important, it's fine. ack then.
instagibbs
force-pushed
the
getnewblockhex_commit
branch
from
98a1547 to
6d9639b
Compare
Contributor
|
ACK 6d9639b |
stevenroose
added a commit
that referenced
this pull request
Oct 28, 2019
…k coinbase c… 6d9639b getnewblockhex: Take data push for arbitrary data in block coinbase commitment (Gregory Sanders) Pull request description: …ommitment Useful for non-consensus proof of publication of data. Tree-SHA512: 8967238c97b5188db50f99d7a8d8a1b26712a6b4c02812880502b5eb9572f7ca6a509a2020cb9661b2931f7d2b06f0580baa8652516b529b2386e92e73767a73
instagibbs
added a commit
that referenced
this pull request
Oct 29, 2019
…in block coinbase c… c79ad5f getnewblockhex: Take data push for arbitrary data in block coinbase commitment (Gregory Sanders) Pull request description: …ommitment backport of #753 Tree-SHA512: b118f33643a5f62978c4d839c7d38917b65fdf7b8ef86fe8091485ea4f80024b5e8dbaecb00b778c8e9898611bc742b4169d5ce69b59dae8faff749d040c5120
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 9, 2020
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 10, 2020
stevenroose
pushed a commit
that referenced
this pull request
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ommitment
Useful for non-consensus proof of publication of data.