-
Notifications
You must be signed in to change notification settings - Fork 400
feature_fedpeg.py: just use testmempoolaccept checking blinded peg-in… #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ok, somehow sidechain2 sees the non-pegin input as already spent, much like the previous test setup. The added mempool check shows that it's unrelated to the later disconnect and block creation. |
f079c60 to
c4ee2a9
Compare
|
ok it's the obvious thing, a block race when selecting this additional input. Previously the test raced forward and could fail because sidechain2 hasn't seen the sourced input. |
|
now getting |
|
Probably the case where the two nodes think they have nothing of use to tell each other when sidechain spams sidechain2 with a bunch of just-immature-to-sidechain2 blocks, and they're all marked invalid. To unstick you just need to see a new block(which means complicating the already-existing sync calls). I sprinkled more syncs during block creation instead to see if that fixes it. Another tactic would be to sync blocks before each claim, make the claim, then sync mempool only, then have sidechain2 make the block. This would ensure no peg-in-invalid blocks get buried in chains of seemingly invalid ones. |
0134373 to
3e912de
Compare
…inded peg-in… 3e912de Sprinkle a bunch of syncs to avoid peg-in failure hanging (Gregory Sanders) 3ac8e29 feature_fedpeg.py: just use testmempoolaccept checking blinded peg-in transactions (Gregory Sanders) Pull request description: … transactions Previous test had race condition causing spurious failures for no additional coverage. Resolves #728 Tree-SHA512: f128bb0b8ad54da683c66bbd6ad1385927659fab4cc8e77e57943dea6c7d989389c39e29ff8d282bdab3e068ec38af449e2941e03f802fe477d839b636587e92
|
ACK 3e912de |
… transactions
Previous test had race condition causing spurious failures for no additional coverage.
Resolves #728