Make MainchainRPCCheck a bit less aggressive #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACK ad43f9c |
stevenroose
added a commit
that referenced
this pull request
May 8, 2019
ad43f9c Only spin-wait MainchainRPCCheck on initial loading with warmup code (Gregory Sanders) 9d4097d Only schedule mainchain RPC checks after initial check succeeds (Gregory Sanders) Pull request description: First, only start scheduling checks if the initial check on load succeeds. This initial check is a sanity-check that makes sure all daemons are spun up and communicating correctly. Second, for the initial check only we want to spin-wait for the mainchaind to finish warming up, otherwise elementsd may fail rather than wait a couple seconds for bitcoind to start up, for instance, which can occur when automating the processes. Previously we were spin-waiting for all instances of MainchainRPCCheck, which means if your bitcoind falls over mid-run for whatever reason and is in warmup state for a long time(say, updating UTXO db), these checks will pile up on each other, spamming your bitcoind with useless RPC calls. Post-init it's completely fine for the call to simply fail and try again in N minutes. resolves #608 Tree-SHA512: 6a02f1b150a8631e36da63a33f9775fbb2cf17aa749e4895b6a947ba605e00ce9fda8349bf7a556e01d9fccaece7387914fb6bb78d7b47c9f272bbcf7f3ff919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, only start scheduling checks if the initial check on load succeeds. This initial check is a sanity-check that makes sure all daemons are spun up and communicating correctly. Second, for the initial check only we want to spin-wait for the mainchaind to finish warming up, otherwise elementsd may fail rather than wait a couple seconds for bitcoind to start up, for instance, which can occur when automating the processes.
Previously we were spin-waiting for all instances of MainchainRPCCheck, which means if your bitcoind falls over mid-run for whatever reason and is in warmup state for a long time(say, updating UTXO db), these checks will pile up on each other, spamming your bitcoind with useless RPC calls. Post-init it's completely fine for the call to simply fail and try again in N minutes.
resolves #608