refactor getpeginaddress to not call getnewaddress RPC #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like I broke something. I'll be adding an additional test case anyways to prevent regressions. |
instagibbs
force-pushed
the
unhack_getpeginaddress
branch
from
3755234 to
b919ca3
Compare
Contributor
Author
|
I had removed the sh_wpkh entry from wallet which it was depending on. Since that's completely not required(we're using wpkh scripts since forever), I refactored |
Contributor
Author
|
They never were, at least in 0.14.
…On Fri, May 3, 2019, 6:10 AM Steven Roose ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/wallet/rpcwallet.cpp
<#602 (comment)>
:
> }
- pwallet->SetAddressBook(w.result, "", "receive");
+ // Use native witness destination
+ CTxDestination dest = GetDestinationForKey(newKey, OutputType::BECH32);
So no more non-bech32 pegin addresses. ACK for me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#602 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABMAFU2GMZ43SZXIUHMLDKTPTQFQZANCNFSM4HJTQGCA>
.
|
stevenroose
added a commit
that referenced
this pull request
May 3, 2019
b919ca3 fedpeg test makes sure claim_script is wpkh (Gregory Sanders) a9cbe55 refactor getpeginaddress to not call getnewaddress RPC (Gregory Sanders) cdb33e5 createrawpegin should look for wpkh addresses, not nested (Gregory Sanders) Pull request description: resolves #599 Tree-SHA512: 37fbcb865df78337827b44fed00e54fcd5c44eea57bf48d66416be00c915129dcc5f5fda613d9f64fdb325303c24fab4a1e8b1c96fd54ee2dcaac90ba841bfb7
Contributor
|
ACK b919ca3 |
jamesdorfman
pushed a commit
to jamesdorfman/elements
that referenced
this pull request
Aug 20, 2024
…ption methods a63b60f refactor: Add OptionsModel getOption/setOption methods (Ryan Ofsky) Pull request description: This is a trivial change which is needed as part of ElementsProject#602 to get bitcoind and bitcoin-qt to use the same settings instead of different settings. It is split off from ElementsProject#602 because it causes a lot of rebase conflicts (any time there is a GUI options change). This PR is very small and easy to review ignoring whitespace: https://github.com/bitcoin-core/gui/pull/600/files?w=1 ACKs for top commit: vasild: ACK a63b60f furszy: Code review ACK a63b60f promag: Code review ACK a63b60f. Tree-SHA512: 1d99a1ce435b4055c1a38d2490702cf5b89bacc7d168c9968a60550bfd9f6dace649d5e98699de68d6305f02d5d1e3eb7e177ab578b98b996dd873b1df0ed236
jamesdorfman
pushed a commit
to jamesdorfman/elements
that referenced
this pull request
Sep 6, 2024
…s to OptionsModel constructor 31122aa refactor: Pass interfaces::Node references to OptionsModel constructor (Ryan Ofsky) Pull request description: Giving OptionsModel access to the node interface is needed as part of ElementsProject#602 to get bitcoind and bitcoin-qt to use the same settings instead of different settings. It has been split off from ElementsProject#602 to simplify that PR. Previously these commits were part of bitcoin/bitcoin#15936 and also had some review discussion there. ACKs for top commit: promag: Code review ACK 31122aa. furszy: Code ACK 31122aa jarolrod: ACK 31122aa Tree-SHA512: b8529322fd7ba97e19864129e6cf5f9acc58c124f2e5a7c50aca15772c8549de3c24e8b0c27e8cf2c06fd26529e9cdb898b0788a1de3cbfdfbdd3f85c9f0fe69
delta1
pushed a commit
to delta1/elements
that referenced
this pull request
Apr 6, 2025
… onion-prev settings 9d3127b Add settings.json prune-prev, proxy-prev, onion-prev settings (Ryan Ofsky) Pull request description: With ElementsProject#602, if proxy and pruning settings are disabled in the GUI and the GUI is restarted, proxy and prune values are not stored anywhere. So if these settings are enabled in the future, default values will be shown, not previous values. This PR stores previous values so they will preserved across restarts. I'm not sure I like this behavior because showing default values seems simpler and safer to me. Previous values may just have been set temporarily and may have never actually worked, and it adds some code complexity to store them. This PR is one way of resolving ElementsProject#596. Other solutions are possible and could be implemented as alternatives. ACKs for top commit: hebasto: ACK 9d3127b, tested on Ubuntu 22.04. vasild: ACK 9d3127b jarolrod: tACK 9d3127b Tree-SHA512: 1778d1819443490c880cfd5c1711d9c5ac75ea3ee8440e2f0ced81d293247163a78ae8aba6027215110aec6533bd7dc6472aeead6796bfbd51bf2354e28f24a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #599