Skip to content

Blockindex compatibility fix, startup speedup #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stevenroose merged 2 commits into from
Mar 28, 2019
Merged

Blockindex compatibility fix, startup speedup #541

stevenroose merged 2 commits into from
Mar 28, 2019

Conversation

@instagibbs
Copy link
Contributor

@instagibbs instagibbs commented Mar 27, 2019 •
edited
Loading

We diverged from the 0.14 codebase, fix included here as well as performance speedup on initial load.

In 0.14 we did no signature checking at all, but the signature checks were what alerted me to the incompatibility, so I opted to preserve some of that as sanity check.

@instagibbs
Copy link
Contributor Author

instagibbs commented Mar 27, 2019 •
edited
Loading

Output from updated instance(14->master) for reference:

gettxoutsetinfo
{
  "height": 234901,
  "bestblock": "eb90f88eee9e0c28998e91c3f341d9ff8f191d8e753b7608b96a242f173d9ba2",
  "transactions": 29614,
  "txouts": 31364,
  "bogosize": 2352300,
  "hash_serialized_2": "2c56d2de39ed8a8e4baee8ba0b28ccdcd42a5a61586f7ada43a4e48d7c8ea24f",
  "disk_size": 3432870,
  "total_amount": 9770549.77818588
}

@instagibbs instagibbs added the needs port Needs backport to a different branch label Mar 27, 2019
@instagibbs
Copy link
Contributor Author

instagibbs commented Mar 27, 2019 •
edited
Loading

On freshly synced elements master: invalidateblock ebf01047f8ca052c858cf6a43f111242a133f4aeb5cefed5d1952683816c0a1d which is height 234902:

gettxoutsetinfo
{
  "height": 234901,
  "bestblock": "eb90f88eee9e0c28998e91c3f341d9ff8f191d8e753b7608b96a242f173d9ba2",
  "transactions": 29614,
  "txouts": 31364,
  "bogosize": 2352300,
  "hash_serialized_2": "2c56d2de39ed8a8e4baee8ba0b28ccdcd42a5a61586f7ada43a4e48d7c8ea24f",
  "disk_size": 3390414,
  "total_amount": 9770549.77818588
}

Now syncing using liquid public release and will post results when finished.

@instagibbs
Copy link
Contributor Author

instagibbs commented Mar 27, 2019 •
edited
Loading

liquid public release sync:

gettxoutsetinfo
{
  "height": 234901,
  "bestblock": "eb90f88eee9e0c28998e91c3f341d9ff8f191d8e753b7608b96a242f173d9ba2",
  "transactions": 29614,
  "txouts": 31364,
  "bytes_serialized": 3073917,
  "hash_serialized": "44f47d09a7f957e44df0f0cc352907d849de1fa400d218d41c33fccb59dc2e51"
}

@instagibbs instagibbs changed the title [WIP] Blockindex compat Blockindex compatibility fix, startup speedup Mar 27, 2019
@stevenroose
Copy link
Contributor

stevenroose commented Mar 28, 2019

tACK 0baa135

Converted my old liquidd in a flash :)

@stevenroose stevenroose merged commit 0baa135 into ElementsProject:master Mar 28, 2019
stevenroose added a commit that referenced this pull request Mar 28, 2019
@stevenroose
Merge #541: Blockindex compatibility fix, startup speedup
09e20ab 
0baa135 Only check 1 in 1000 block header sigs on load (Gregory Sanders)
87c06d4 Save some space, maintain compatibility with elements-0.14 header index (Gregory Sanders)

Pull request description:

  We diverged from the 0.14 codebase, fix included here as well as performance speedup on initial load.

  In 0.14 we did no signature checking at all, but the signature checks were what alerted me to the incompatibility, so I opted to preserve some of that as sanity check.

Tree-SHA512: 565c9d771e8f7a1057f7dcd1107c9d3f23159d3cf9f9968fdc53f7732abdfbf8a65e3c0a42807fbb80c712cb65d6fa2a7c83c3bf3de5ac0a6b72b49e55f00e83
@instagibbs instagibbs mentioned this pull request Mar 28, 2019
Closed
@instagibbs instagibbs removed the needs port Needs backport to a different branch label Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@instagibbs @stevenroose