[0.17] Disallow extended encoding for non-witness transactions #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenroose
changed the title
instagibbs
reviewed
Mar 21, 2019
| if (!tx.HasWitness()) { | ||
| /* It's illegal to encode witnesses when all witness stacks are empty. */ | ||
| throw std::ios_base::failure("Superfluous witness record"); | ||
| } |
Contributor
There was a problem hiding this comment.
I think we already check this condition in the witness serialization itself, but doesn't hurt here either.
Contributor
|
utACK e11c6f5 |
instagibbs
added a commit
that referenced
this pull request
Mar 21, 2019
…tions e11c6f5 Disallow extended encoding for non-witness transactions (Pieter Wuille) Pull request description: backport of #402 which is a backport of upstream Tree-SHA512: 01cccbc0d54a9f039ed16c88f1d9ec7ebac3a936fb4a77e664c9103e06bb142741a743ac980887ec16570429ccc0f9614e5b3076084b1c949190b3169844ed7d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #402 which is a backport of upstream