[0.17] Change branding from bitcoin to elements #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
Contributor
|
concept ACK, linked in parent issue |
instagibbs
changed the title
stevenroose
force-pushed
the
e17-rebranding
branch
3 times, most recently
from
ef99d16 to
c9462be
Compare
stevenroose
force-pushed
the
e17-rebranding
branch
6 times, most recently
from
a3776c7 to
4ab42e4
Compare
Contributor
|
Apple build failed: Restarting in case it's a freak accident because I blew away cache. |
stevenroose
force-pushed
the
e17-rebranding
branch
from
4ab42e4 to
d1f5351
Compare
instagibbs
approved these changes
Mar 22, 2019
Contributor
instagibbs
left a comment
instagibbs
left a comment
There was a problem hiding this comment.
utACK.
Looks good, if we're going with the idea for default datadir to be .elements, which may make sense considering we have Bitcoin compatibility model and people may want to play with that.
Any serious deployment is likely creating a custom path anyways.
| export LC_ALL=C.UTF-8 | ||
|
|
||
| DOCKER_EXEC echo \> \$HOME/.bitcoin # Make sure default datadir does not exist and is never read by creating a dummy file | ||
| DOCKER_EXEC echo \> \$HOME/.elements # Make sure default datadir does not exist and is never read by creating a dummy file |
Contributor
There was a problem hiding this comment.
is this really used? We still use .bitcoin generally right?
Contributor
There was a problem hiding this comment.
read more, it is correct :)
| #else | ||
| // Unix | ||
| return pathRet / ".bitcoin"; | ||
| return pathRet / ".elements"; |
Contributor
There was a problem hiding this comment.
Do we want to do this? It's always been .bitcoin, except for Liquid public release which was .liquid.
instagibbs
added a commit
that referenced
this pull request
Mar 22, 2019
d1f5351 Update man pages (Steven Roose) e1cd00c Change branding from bitcoin to elements (Steven Roose) ade539c Don't assume mainchain is Bitcoin (Steven Roose) cf77a23 Update README to Elements Project (Steven Roose) Pull request description: Tree-SHA512: f9428219b15a52fd6cff63e7a725a4cb67a3dbecf59eaf7ca946a2b1af8b803bd75c3a62f1feacc8356ae21d32b308cafb27a254d52db6a462563a82b271e101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.