Disallow extended encoding for non-witness transactions #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Apparently fails functional tests upstream, please tag the commit as an ustream fix: bitcoin/bitcoin#14039 |
Contributor
|
ok that might be an upstream problem only |
Contributor
|
Should we move forward with this or close it? |
Contributor
|
it's not super urgent, let's just wait |
instagibbs
added a commit
that referenced
this pull request
Mar 21, 2019
…tions e11c6f5 Disallow extended encoding for non-witness transactions (Pieter Wuille) Pull request description: backport of #402 which is a backport of upstream Tree-SHA512: 01cccbc0d54a9f039ed16c88f1d9ec7ebac3a936fb4a77e664c9103e06bb142741a743ac980887ec16570429ccc0f9614e5b3076084b1c949190b3169844ed7d
Contributor
|
tested and merged version in master, merging. |
instagibbs
added a commit
that referenced
this pull request
Mar 25, 2019
8719c94 Disallow extended encoding for non-witness transactions (Pieter Wuille) Pull request description: Backport from upstream bitcoin/bitcoin#14039 Tree-SHA512: a91810e0afe4d631e2e08cd1bc919e83e3dbdac050f1a66ddc0c6210b222e5813f5b36b27111976e83a4c7683507e4ed06ef475467e1c0e572ccb3d0abc631e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from upstream bitcoin/bitcoin#14039