RPC: Signblock: Support signblock info on rpc/blockchain #344
Conversation
|
concept ACK |
|
Add some really basic rpc test and I'll merge |
jtimon
force-pushed
the
e14-cleanup-pow
branch
4 times, most recently
from
4ecca9d to
c49cfb4
Compare
|
utACK c49cfb4 thank you for adding tests |
jtimon
force-pushed
the
e14-cleanup-pow
branch
2 times, most recently
from
4831d31 to
3ef4828
Compare
jtimon
force-pushed
the
e14-cleanup-pow
branch
2 times, most recently
from
8fda7d4 to
b821e10
Compare
jtimon
changed the title
|
It seems I found out what was happening with travis. I will squash. Should I squash only that commit or do more squashing? |
|
wow, how couldn't we figure this out... please squash into whatever you find sensible, I need to review it again |
|
Squashed only the fixup commit for now, feel free to ask for further squashing. |
instagibbs
changed the title
|
Apologies, could you squash the first QA one, at least, since it'll make the previous commit fail atomically? I don't mind logic+qa changes in same commit at all. Otherwist, utACK! |
|
I'm fine squashing both qa changes with their respective changes or even everything in one commit. At first it was just one commit for the changes and another activating and improving the tests, but after the confusing I ended up separating things more to divide and conquer and now the test re-activation is already merged. |
QA: Adapt rpc_blockchain tests to not having pow
QA: Adapt rpc_blockchain tests to signed blocks
2 participants
Bigger refactor than I initially thought.
But basically still cleaning up pow stuff we don't need, and including a few new blocksign-related fields that replace those and document them.
Doesn't come with tests, but if it's not only rpc, then nack, please.
Dependencies:
- [ ] RPC: Stop providing useless fake pow data RPC: Stop providing useless fake pow data #366