chore: replaced the non-working travis badge with a release #1473
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about the shields.io URL? Maybe just clean-remove Travis link first? |
|
ACK 637fbf9 - dependency on external domain |
Contributor
Author
|
delta1
approved these changes
Jul 7, 2025
Member
delta1
left a comment
delta1
left a comment
There was a problem hiding this comment.
ACK 637fbf9
Certainly an improvement compared to a broken travis badge. Not too bothered about the external domain, shields has been around for a long time and we can always change it if it falls over.
The readme could use a partial/complete rewrite anyway.
Thanks @Olexandr88
delta1
reviewed
Jul 7, 2025
README.md
Outdated
| ==================================== | ||
|
|
||
| [](https://travis-ci.org/ElementsProject/elements) | ||
| [](https://github.com/ElementsProject/elements/releases) |
Member
There was a problem hiding this comment.
Suggested change
| [](https://github.com/ElementsProject/elements/releases) | |
|  |
This changes the text to "latest release" and links directly to it
|
Yes. Sounds good to me.
By the way Releases of Elements Core are available first-hand at
https://github.com/ElementsProject/elements/releases and I would recommend
using this link if you'd like to add one.
…On Sun, Jul 6, 2025, 21:22 Olexandr88 ***@***.***> wrote:
*Olexandr88* left a comment (ElementsProject/elements#1473)
<#1473 (comment)>
А як щодо URL-адреси shields.io? Можливо, спочатку просто видалити
посилання на Тревіса?
Hey @jsarenik <https://github.com/jsarenik> if necessary I can just
remove the travis icon
—
Reply to this email directly, view it on GitHub
<#1473 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB3WVN4QSDS7XLSZTDND4T3HFZQ5AVCNFSM6AAAAACA4QBJPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANBSGM2TCNZXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
delta1
added a commit
to delta1/elements
that referenced
this pull request
Jul 9, 2025
delta1
added a commit
to delta1/elements
that referenced
this pull request
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.