Removed duplicate solving_data for transaction funding RPCs #1471
+9
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomt1664
force-pushed
the
fix/duplicate_solve_data
branch
from
e7921a0 to
a9da179
Compare
Member
Author
|
re-based to master |
delta1
approved these changes
Jul 8, 2025
delta1
reviewed
Jul 9, 2025
| uint32_t psbt_version = 2; | ||
| if (!request.params[6].isNull()) { | ||
| if (!request.params[5].isNull()) { | ||
| psbt_version = request.params[6].get_int(); |
Member
There was a problem hiding this comment.
Hey @tomt1664 just spotted this, should be params[5] here? Presumably I've fixme'd out some test code that would have caught this
psbt_version = request.params[5].get_int();
Member
Author
There was a problem hiding this comment.
Yes, you are right - should be params[5].
As afar as I can see there is no test (including fixmes) that check this.
I will update and add a test case to catch this.
delta1
added a commit
to delta1/elements
that referenced
this pull request
Jul 9, 2025
delta1
added a commit
to delta1/elements
that referenced
this pull request
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solving_dataremoved as explicit arguments forwalletcreatefundedpsbtandfundrawtransactionwhere the argument was being ignored.solving_dataremains part of theoptionsexplicit argument.Fixes: #1470