discount: fix weight calculation #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Jon Griffiths for picking up that the amount and nonce discount should be multiplied by the witness scaling factor as they form part of the base transaction.
delta1
changed the title
This was referenced Sep 25, 2024
apoelstra
approved these changes
Sep 25, 2024
apoelstra
approved these changes
Sep 25, 2024
apoelstra
added a commit
to ElementsProject/rust-elements
that referenced
this pull request
Sep 25, 2024
6909e1c discount: fix calculation to weight amount and nonce by witness scaling factor (Byron Hambly) Pull request description: output amount and nonce discount must be weighted by the witness scaling factor as they form part of the base transaction, not the witness data see ElementsProject/elements#1366 ACKs for top commit: apoelstra: ACK 6909e1c successfully ran local tests; though I note that if we had a Weight type here like in rust-bitcoin we likely would have caught this :/ Tree-SHA512: 4348d32a980088e7426c03c5c9f42bfb130fefbbe18167725e75a6decff4acb069b4f2dea3d8eb1beac1d93a7c16e7acc9ee1f47f8953ffb4e786fb5fe430dc3
Contributor
|
tAck 09c5068 |
Merged
apoelstra
added a commit
to ElementsProject/ELIPs
that referenced
this pull request
Sep 27, 2024
9f08b81 elip200: fix discount weight calculation for asset and nonce (Byron Hambly) Pull request description: output amount and nonce discount must be weighted by the witness scaling factor as they form part of the base transaction, not the witness data see ElementsProject/elements#1366 and ElementsProject/rust-elements#218 ACKs for top commit: apoelstra: ACK 9f08b81 Tree-SHA512: c719cd0343887d11b28037cb1b15da73b9d139f95a8c75bb91dd8ea126ed8cf8781485dd6ef26304adb8cd1a08b60c4ee0a14480f25619950f67a1d394d64e3e
jamesdorfman
added a commit
to jamesdorfman/elements
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the discount calculation by multiplying the amount and nonce discounts by the witness scaling factor (4) as they form part of the base transaction. thanks to @jgriffiths !
also adds
discountweightnext todiscountvsizein TxToUniv response if node accepts Discount CT