Skip to content

Obscure mainchain rpc fields in the logs, just like the local ones #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
delta1 merged 1 commit into from
Feb 1, 2023
Merged

Obscure mainchain rpc fields in the logs, just like the local ones #1206

delta1 merged 1 commit into from
Feb 1, 2023

Conversation

@psgreco
Copy link
Contributor

@psgreco psgreco commented Jan 31, 2023

Mark mainchainrpcuser and mainchainrpcpassword as sensitive, just as rpcuser and rpcpassword, so they are not shown in the logs.
Before:

2023-01-31T21:57:28Z Config file arg: [liquidtestnet] mainchainrpcpassword="bbbbbb"
2023-01-31T21:57:28Z Config file arg: [liquidtestnet] mainchainrpcuser="aaaaaaa"

After:

2023-01-31T21:58:44Z Config file arg: [liquidtestnet] mainchainrpcpassword=****
2023-01-31T21:58:44Z Config file arg: [liquidtestnet] mainchainrpcuser=****

Fixes: #1205

@gwillen
Copy link
Contributor

gwillen commented Jan 31, 2023

good idea, utACK.

@delta1 delta1 merged commit 2f7bf3e into ElementsProject:master Feb 1, 2023
@psgreco psgreco deleted the master-hide-rpcpasswords branch February 13, 2023 16:12
jamesdorfman added a commit to jamesdorfman/elements that referenced this pull request Mar 13, 2023
@jamesdorfman
Merge 2f7bf3e into merged_master (Elements PR ElementsProject#1206)
400c502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Obscure the mainchainrpcpassword value in debug.log (just as with rpcpassword=****)

3 participants

@psgreco @gwillen @delta1