gui: Add thread to run background activity in WalletController

promag · promag · commit be82dea23c3e · 2019-02-04T12:20:42.000Z
diff --git a/src/qt/walletcontroller.cpp b/src/qt/walletcontroller.cpp
@@ -26,11 +26,17 @@ WalletController::WalletController(interfaces::Node& node, const PlatformStyle*
     for (std::unique_ptr<interfaces::Wallet>& wallet : m_node.getWallets()) {
         getOrCreateWallet(std::move(wallet));
     }
+
+    m_activity_thread.start();
 }
 
 // Not using the default destructor because not all member types definitions are
 // available in the header, just forward declared.
-WalletController::~WalletController() {}
+WalletController::~WalletController()
+{
+    m_activity_thread.quit();
+    m_activity_thread.wait();
+}
 
 std::vector<WalletModel*> WalletController::getWallets() const
 {
diff --git a/src/qt/walletcontroller.h b/src/qt/walletcontroller.h
@@ -13,6 +13,7 @@
 #include <vector>
 
 #include <QMutex>
+#include <QThread>
 
 class OptionsModel;
 class PlatformStyle;
@@ -51,6 +52,7 @@ private Q_SLOTS:
     void coinsSent(WalletModel* wallet_model, SendCoinsRecipient recipient, QByteArray transaction);
 
 private:
+    QThread m_activity_thread;
     interfaces::Node& m_node;
     const PlatformStyle* const m_platform_style;
     OptionsModel* const m_options_model;

Original file line number	Diff line number	Diff line change
`@@ -26,11 +26,17 @@ WalletController::WalletController(interfaces::Node& node, const PlatformStyle*`
`26`	`26`	`for (std::unique_ptr<interfaces::Wallet>& wallet : m_node.getWallets()) {`
`27`	`27`	`getOrCreateWallet(std::move(wallet));`
`28`	`28`	`}`
	`29`	`+`
	`30`	`+ m_activity_thread.start();`
`29`	`31`	`}`
`30`	`32`
`31`	`33`	`// Not using the default destructor because not all member types definitions are`
`32`	`34`	`// available in the header, just forward declared.`
`33`		`-WalletController::~WalletController() {}`
	`35`	`+WalletController::~WalletController()`
	`36`	`+{`
	`37`	`+ m_activity_thread.quit();`
	`38`	`+ m_activity_thread.wait();`
	`39`	`+}`
`34`	`40`
`35`	`41`	`std::vector<WalletModel*> WalletController::getWallets() const`
`36`	`42`	`{`