Made expicit constructor CTransaction(const CMutableTransaction &tx).

lucash-dev · lucash-dev · commit b301950df324 · 2018-12-17T21:02:42.000-08:00
This makes the above constructor explicit. The rationale is that this conversion has very significant performance effects. Making it explicit makes it easier to reason about these performance trade-offs, and helps identify possible functions that need a CMutableTransaction version.
diff --git a/src/primitives/transaction.h b/src/primitives/transaction.h
@@ -298,7 +298,7 @@ class CTransaction
     CTransaction();
 
     /** Convert a CMutableTransaction into a CTransaction. */
-    CTransaction(const CMutableTransaction &tx);
+    explicit CTransaction(const CMutableTransaction &tx);
     CTransaction(CMutableTransaction &&tx);
 
     template <typename Stream>
