When RPC server disabled, only warn on validatepegin failure

instagibbs · instagibbs · commit 2362c005f339 · 2019-11-05T13:27:54.000-05:00
diff --git a/src/init.cpp b/src/init.cpp
@@ -1876,10 +1876,17 @@ bool AppInitMain(InitInterfaces& interfaces)
 
     // ELEMENTS:
     uiInterface.InitMessage(_("Awaiting mainchain RPC warmup"));
-    if (!MainchainRPCCheck(true)) { //Initial check, fail immediately
-        return InitError(_("ERROR: elementsd is set to verify pegins but cannot get valid response from the mainchain daemon. Please check debug.log for more information.")
-        + "\n\n"
-        + strprintf(_("If you haven't setup a %s please get the latest stable version from %s or if you do not need to validate pegins set in your elements configuration %s"), "bitcoind", "https://bitcoincore.org/en/download/", "validatepegin=0"));
+    if (!MainchainRPCCheck(true)) { //Initial check only
+        const std::string err_msg = "ERROR: elements is set to verify pegins but cannot get valid response from the mainchain daemon. Please check debug.log for more information.\n\nIf you haven't setup a bitcoind please get the latest stable version from https://bitcoincore.org/en/download/ or if you do not need to validate pegins set in your elements configuration validatepegin=0";
+        // We fail immediately if this node has RPC server enabled
+        if (gArgs.GetBoolArg("-server", false)) {
+            InitError(err_msg);
+            return false;
+        } else {
+            // Or gently warn the user, and continue
+            InitWarning(err_msg);
+            gArgs.SoftSetArg("-validatepegin", "0");
+        }
     }
 
     // Start the lightweight block re-evaluation scheduler thread
