GUI: Ignore explicit fee output when determining if a transaction is send-to-self

luke-jr · instagibbs · commit 0aeab14f75f4 · 2019-04-08T11:09:16.000-04:00
diff --git a/src/qt/transactionrecord.cpp b/src/qt/transactionrecord.cpp
@@ -85,8 +85,13 @@ QList<TransactionRecord> TransactionRecord::decomposeTransaction(const interface
         }
 
         isminetype fAllToMe = ISMINE_SPENDABLE;
-        for (const isminetype mine : wtx.txout_is_mine)
-        {
+        for (unsigned int i = 0; i < wtx.txout_is_mine.size(); ++i) {
+            const isminetype mine = wtx.txout_is_mine[i];
+            const CTxOut txout = wtx.tx->vout[i];
+            if (txout.IsFee()) {
+                // explicit fee; ignore
+                continue;
+            }
             if(mine & ISMINE_WATCH_ONLY) involvesWatchAddress = true;
             if(fAllToMe > mine) fAllToMe = mine;
         }
