elip200: fix discount weight calculation for asset and nonce #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think you should change |
delta1
force-pushed
the
discountweight
branch
from
372a8fd to
b80157c
Compare
Member
Author
Thanks, done in b80157c |
Member
|
Now it descrbes the commitment as beeing "33 wu" which is incorrect. It is either "33 bytes" or "132 wu". Same for the "no nonce" case. Also the text "multiplied by 4 as part of the base transaction weight" is confusing. I'm not sure what it's supposed to mean. I guess you mean "the number of bytes is multiplied by 4 since this is non-witness data" but the number of bytes is not the subject of this sentence. |
delta1
force-pushed
the
discountweight
branch
from
b80157c to
9f08b81
Compare
Member
Author
|
updated in 9f08b81 |
apoelstra
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output amount and nonce discount must be weighted by the witness scaling factor as they form part of the base transaction, not the witness data
see ElementsProject/elements#1366 and ElementsProject/rust-elements#218