Sync with dexmaker #737
Merged
Sync with dexmaker #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains changes from linkedin/dexmaker@1bb921e, linkedin/dexmaker@a863767, linkedin/dexmaker@7929d11, linkedin/dexmaker@53339f9, linkedin/dexmaker@4b7c28b
kotori2
reviewed
Dec 18, 2020
| } | ||
|
|
||
| EncodedMethod toEncodedMethod(DexOptions dexOptions) { | ||
| if ((flags & ABSTRACT) != 0 || (flags & NATIVE) != 0) { |
Contributor
There was a problem hiding this comment.
I think dexmaker is just for hooker generation, what's the point of checking native flags here?
Contributor
Author
There was a problem hiding this comment.
I believe that native methods don’t have bodies so they should be handled like abstract methods. Anyways, I imported missing changes to be more in line with original dexmaker, so I don't believe this change would do any harm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some commits related to dexmaker are missing.
List of changes in this PR:
linkedin/dexmaker@1bb921e
linkedin/dexmaker@a863767
linkedin/dexmaker@7929d11
linkedin/dexmaker@53339f9
linkedin/dexmaker@4b7c28b
I tested these changes for a long while, everything seems to be fine.