This repository was archived by the owner on Jul 2, 2024. It is now read-only.
Clear out ElasticResponse large hits collection after done materializing.#94
Merged
Conversation
…ing. A large enough hits list will end up getting allocated on the large object heap, which will pin all the result documents in memory longer than necessary.
| if (response.hits != null) | ||
| { | ||
| var hits = response.hits.hits; | ||
| if (hits != null && hits.Capacity > 4096) |
Collaborator
There was a problem hiding this comment.
Is there any harm in just always clearing the hits after materialization?
Contributor
Author
There was a problem hiding this comment.
Probably not. I guess zeroing out an array should be fairly well optimized in .net.
Collaborator
|
The following change would probably be better for memory... but worse for perf (in ListHitsElasticMaterializer) internal static IEnumerable<T> Many<T>(List<Hit> hits, Func<Hit, object> projector)
{
while (hits.Count > 0)
{
var result = (T)projector(hits[0]);
hits.RemoveAt(0);
yield return result;
}
}Thoughts? |
Contributor
Author
|
Could probably write a quick app to compare, but my intuition tells me it'll be pretty bad since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A large enough hits list will end up getting allocated on the large object heap, which will pin all the result documents in memory longer than necessary.
This is one of the changes to address issues mentioned in #89