Skip to content
This repository was archived by the owner on Jul 2, 2024. It is now read-only.

Add support for prefix of string collection fields#75

Merged
damieng merged 2 commits into
ElasticLINQ:devfrom
mvalipour:dev
Aug 30, 2015
Merged

Add support for prefix of string collection fields#75
damieng merged 2 commits into
ElasticLINQ:devfrom
mvalipour:dev

Conversation

@mvalipour

Copy link
Copy Markdown

I know unit-tests are yet to be done on this change, but I'm raising this early so we can have discussion around this.

In elastic search world, you can use prefix for both string fields and string[] fields, but only the former is currently supported on elasticLINQ.

this PR is adding support for the latter and it's surprizingly simple! :)
basically the entire expression mapping just works fine.

Please let me know what you think.

@damieng

damieng commented Aug 25, 2015

Copy link
Copy Markdown
Collaborator

Sounds good - go ahead and add a few unit tests to ensure it flows through nicely and we can probably get this into 1.4

@mvalipour

Copy link
Copy Markdown
Author

@damieng I've added some tests -- basically same sort of tests that was there for Prefix

On a side note: I was going to create a nuget package of my custom build and use it until 1.4 is out (to include this feature). However, using build.ps1 Packages doesn't seem to produce a nupkg that is usable (there are package dependency problems).

is there any specific way you produce your publishable nuget package? -- is ILMerge involved?

@mvalipour mvalipour closed this Aug 26, 2015
@mvalipour mvalipour reopened this Aug 26, 2015
@damieng

damieng commented Aug 27, 2015

Copy link
Copy Markdown
Collaborator

I normally just use build packages. There were some recent changes to switch to NuGet only profile111 to allow it to be used on a variety of platforms. What dependency issue were you seeing?

I'm going to see if we can get 1.4 out over the next few days.

@mvalipour

Copy link
Copy Markdown
Author

There seem to be a dependency to System.Runtime

@mvalipour

Copy link
Copy Markdown
Author

If 1.4 is going to be out in the next few days, I may well wait for the official package.

there is no nightly dev builds by any chance, is there?

@damieng damieng added this to the 1.4 milestone Aug 27, 2015
@damieng

damieng commented Aug 27, 2015

Copy link
Copy Markdown
Collaborator

Can you see if master at 5c031cf works fine for you with regards to the NuGet package? If it does we'll back out the Profile111 switch until after 1.4 in order to get this out quicker.

damieng added a commit that referenced this pull request Aug 30, 2015
Add support for prefix of string collection fields
@damieng
damieng merged commit 3824906 into ElasticLINQ:dev Aug 30, 2015
@damieng

damieng commented Aug 31, 2015

Copy link
Copy Markdown
Collaborator

The Profile111 work is backed out, let me know if that lets you create a nuget package without problem.

@mvalipour

Copy link
Copy Markdown
Author

Sure, will do and let you know.

thanks :)

@mvalipour

Copy link
Copy Markdown
Author

@damieng Tested and all works perfectly 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants