This repository was archived by the owner on Jul 2, 2024. It is now read-only.
Highlight support#63
Merged
Merged
Conversation
Collaborator
|
Hi @AlexzundeR welcome to the project! This feature looks interesting and we'd love to take this further. I have a few points:
I'll check out the code a bit more this weekend - let me know if you need any clarification on these points. Thanks! |
added 3 commits
May 15, 2015 16:31
…ogic in highlight extentions. Create posibility to made chain of calls Highlight extention method.
Contributor
Author
|
Hi @damieng !
I added functionality of chain calling of my extention, to add many properties to highlighting to request. Thank for feedback=) |
Contributor
Author
|
I added some tests for Materializers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I expand your core, add new criteria, add new fields to base entities that needs to support highlight request and response. Add new type of materializer, that can preprocess response after it become collection of entities (to do this I had to change logic of process query by main visitor, that can now recognize that here is chainMaterializer and create simple response processing chain).
PS I am team lead on project that is very interested in your library, and I want to help you to improve it and make it more usefull and beatyfull =)
PPS sory for my English =)