Repository navigation
Add HttpApi.RedactedNames for span redaction of query and header names - #9995
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: bc81b81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
tim-smart
force-pushed
the
agent/nelson/62fad96349a3
branch
from
November 10, 2026 20:51
26057be to
bc81b81
Compare
tim-smart
enabled auto-merge (squash)
November 10, 2026 20:53
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
HttpApi.RedactedNames, an annotation that lists query parameter and header wire names to redact in spans. It covers values that are only sometimes secret, like Docker'sbuildargsorremote, which aren't modelled asRedacted. Requested in a comment on #9882.UrlParams.CurrentRedactedNamesandHeaders.CurrentRedactedNamesinstead of replacing them, so defaults likesigstill apply. A string query name also matches nested keys such asbuildargs[NPM_TOKEN].HttpApiBuilderwrites the names into the request state before middleware and decoding run, so a 400 is redacted too.HttpMiddleware.traceradds them to the fiber refs for the URL and header attributes. The tracer records attributes after the handler has restored its context, so a scoped update wouldn't reach them.Out of scope, and documented on the annotation:
addHttpApitreatsRedactedNameslike any other annotation, anduser_agent.originaland span error messages are recorded as is. Dropping the query string from server error messages is tracked separately.Closes EFF-2975