Repository navigation
Conversation
Statement.defaultTransforms read `constructor` from the first array item and assumed every later item was an object. A JSON array such as `[null]`, which PostgreSQL's `json_agg` returns for an empty LEFT JOIN, made `transformResultNames` throw a TypeError, and `sql.json` values failed the same way with `transformQueryNames`. Number and string items after an object were replaced with objects. Co-Authored-By: Claude Opus 5.5 <[email protected]>
MaxFreedomPollard
had a problem deploying
to
fork
October 23, 2026 01:43 — with
GitHub Actions
Error
🦋 Changeset detectedLatest commit: b993f06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Statement.defaultTransformsbackstransformResultNames, and also thesql.jsonhandling oftransformQueryNamesin@effect/sql-pgand@effect/sql-pglite. It readconstructorfrom the first item of every array and treated every later item as an object:PostgreSQL's
json_aggreturns[null]for an emptyLEFT JOINgroup.@effect/sql-pgparsesjsoncolumns and applies nested transforms by default, so withtransformResultNamesset such a query dies with the first TypeError. WithtransformQueryNamesset, compilingsql.json([null])throws the same error.Array items that are not objects are now kept as they are. As before, the first item decides whether an array is transformed at all, so arrays of dates, numbers or strings are returned unchanged.
The test in
packages/effect/test/sql/Statement.test.tscovers[null]and mixed object/null/scalar arrays for both the nested and flat transforms.Validation:
pnpm vitest run packages/effect/test/sql/Statement.test.tspasses (11 tests) and the new test fails without the fix.pnpm lintandtsc -bforpackages/effectpass.Closes EFF-2841
🤖 Generated with Claude Code